Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interview dao documentation #873

Merged
merged 14 commits into from
Mar 5, 2025
Merged

Conversation

JasonMun7
Copy link
Contributor

Summary

This PR adds documentation for the InterviewSlotDao.ts

  • Added documentation for the DAO for the interview slots objects

@JasonMun7 JasonMun7 requested a review from a team as a code owner March 3, 2025 01:28
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 39.

@JasonMun7 JasonMun7 changed the title Jjm493/interview dao documentation Interview dao documentation Mar 3, 2025
@JasonMun7 JasonMun7 requested a review from cchrischen March 4, 2025 03:36
Copy link
Collaborator

@cchrischen cchrischen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for getting this done!

@@ -49,6 +77,12 @@ export default class InterviewSlotDao extends BaseDao<InterviewSlot, DBInterview
);
}

/**
* Updates an interview slot, ensuring that only an admin can change the assigned applicant.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applicants and members can also edit interview slots (signing up). admin bypass is to prevent the checks seen later in the code.

@JasonMun7 JasonMun7 merged commit 8b57a8c into main Mar 5, 2025
12 checks passed
@JasonMun7 JasonMun7 deleted the jjm493/interview-dao-documentation branch March 5, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants